Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update landing page to match issue discussion in #94 #101

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Nov 14, 2017

This is just an attempt to capture where #94 has gone. It may still be too strict in some spots, and I'll update as I see the discussions shift.


Preview | Diff

@mattgarrish
Copy link
Member Author

Yes, I'm not saying this is a consensus proposal at this point, or ready for inclusion. I just wanted to start updating the text so there's something to read.

@BigBlueHat
Copy link
Member

@mattgarrish I think you handled the situation nicely and am 👍 on merging this and moving forward.

index.html Outdated
@@ -1,4 +1,4 @@
<!DOCTYPE html>
la<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one thing I don't approve of in this text. 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I would have caught it eventually...

@HadrienGardeur
Copy link

👎 from me as long as we keep the following requirements:

These are IMO TBD and it's not clear if these requirements can be realistically achieved.

@BigBlueHat
Copy link
Member

These are IMO TBD and it's not clear if these requirements can be realistically achieved.

@HadrienGardeur you're going to have to be clearer what you mean by "realistically achieved" and what things prevent those from being MUSTs.

@mattgarrish
Copy link
Member Author

Given that the thread was about adding these, I can't see taking them out as reasonable to closing #94. We don't have complete agreement, obviously, but the numbers are on the side of this interpretation right now.

Let's pick up their merits in more focused issues.

@HadrienGardeur
Copy link

There's no consensus on the entry page being a resource of the Web Publication, several other members of this group have also pointed that out, including @GarthConboy in #94 (comment)

@mattgarrish mattgarrish merged commit 693578f into master Nov 14, 2017
@mattgarrish mattgarrish deleted the landing-page branch November 14, 2017 17:57
@BigBlueHat
Copy link
Member

@mattgarrish this line could use some clarification--and may be part of the conflation between identification and discovery:

Unlike other resources, the entry page MUST link to the manifest to ensure that user agents can discover the Web Publication.

Do you mean "discover that this thing is a Web Publication?" or do you mean something more vague like "search engine discovery of Web Publications?"

If you're referring to "identification as a Web Publication," then that text needs revision.

@BigBlueHat
Copy link
Member

@HadrienGardeur that was also in the context of "landing page" being conflated with an advertising page--which is not the intent here. The goal of this (and @mattgarrish's wise renaming to "entry page") is to have a known and predetermined extensible format sent in response to a request for a Web Publication.

There's still lots to be determined about what role(s) this entry page might play in the spec and in implementations.

@HadrienGardeur
Copy link

@BigBlueHat sorry but I don't see your point. Renaming "landing page" to "entry point" is something completely different from saying that the "entry point" MUST be within the boundaries of the WP.

@BigBlueHat
Copy link
Member

@HadrienGardeur well, at this point, filing an issue about the MUST is the best course of action as these comments are all quite hidden post-merge.

@HadrienGardeur
Copy link

How convenient, let's merge things first then delay further discussions until the end of time...

@BigBlueHat
Copy link
Member

@HadrienGardeur not delaying further discussion. Just trying to focus discussion. File the issue, and lets talk there. If you feel it really is broken this way, then it's worthy of its own problem/solution definition and focused discussion.

@GarthConboy
Copy link
Contributor

And, FWIW, I'm fine with merging and starting a new issue, but in response to @HadrienGardeur:

  • The entry page MUST be a resource of the Web Publication
  • The entry page MUST link to the manifest

I think the first is, indeed, TBD. The second, however, I think should be retained.

@mattgarrish
Copy link
Member Author

If you're referring to "identification as a Web Publication," then that text needs revision.

Sorry, I saw this and then lost track of it. Yes, it's the former. Maybe this is all that needs saying:

the entry page MUST link to the manifest to ensure that user agents can locate that document.

@mattgarrish
Copy link
Member Author

An additional change was made in PR #105 to change the requirement the entry page be a publication resource from MUST to SHOULD.

The requirements are:

MUST be an HTML document
MUST include a link to the manifest
SHOULD be a publication resource

@iherman
Copy link
Member

iherman commented Nov 21, 2017

Merge also discussed and approved on telco, 2017-11-21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants